View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002699SOGoBackend Generalpublic2014-04-03 11:452014-04-09 23:31
Reporterdekkers Assigned Toludovic  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version2.2.2 
Target Version2.2.4Fixed in Version2.2.4 
Summary0002699: test_parsing unit test fails
Description

The test_parsing unit tests fails:

======================================================================
FAIL: test_parsing (TestVersit.m:151)

objects 'BEGIN:GROUP1
ELEMENT:value1\;value2
END:GROUP1' and 'BEGIN:GROUP1
ELEMENT:value1;value2
END:GROUP1' differs

I traced the problem to commit bcb0764b1901f8ea9ee799a80594ae554e80e827, before that commit the unit test didn't fail.

Steps To Reproduce

Run "make check"

TagsNo tags attached.

Activities

ludovic

ludovic

2014-04-03 19:09

administrator   ~0006826

Low-priority item, as it's the test that is broken.
ludovic

ludovic

2014-04-09 23:31

administrator   ~0006866

Last edited: 2014-04-09 23:31

In fact, the test is somehow wrong.

We introduced special handling of list-component in commit bcb0764b1901f8ea9ee799a80594ae554e80e827 to avoid nasty effects when someone would specify a SUMMARY with a value like:

SUMMARY: foo;bar;zot

This would create havoc in the parsing as SOPE NGCards was too generic and would handle everything as list-elements, even for single-value element.

The corrected test case is pushed:

https://github.com/inverse-inc/sogo/commit/5739356f8884c005c5152d730807ecd1275d2426

Issue History

Date Modified Username Field Change
2014-04-03 11:45 dekkers New Issue
2014-04-03 19:09 ludovic Note Added: 0006826
2014-04-03 19:09 ludovic Target Version => 2.2.4
2014-04-09 23:31 ludovic Note Added: 0006866
2014-04-09 23:31 ludovic Status new => resolved
2014-04-09 23:31 ludovic Fixed in Version => 2.2.4
2014-04-09 23:31 ludovic Resolution open => fixed
2014-04-09 23:31 ludovic Assigned To => ludovic
2014-04-09 23:31 ludovic Note Edited: 0006866