|
|
Any News? This Problem is serious ... |
|
|
|
confirm to this BUG
verifyed with sogo on lates tb 17 esr and 24 with owncloud
PUT /remote.php/carddav/addressbooks/[..]/contacts/[..].vcf HTTP/1.1" 412 249
Err (Sabre_DAV_Exception_PreconditionFailed):
An If-None-Match header was specified, but the ETag matched (or * was specified).
If-None-Match
Bad solution for owncloud 5
edit
vi +1957 3rdparty/Sabre/DAV/Server.php
if ($ifNoneMatch = $this->httpRequest->getHeader('If-None-Match')) {
// The If-None-Match header contains an etag.
// Only if the ETag does not match the current ETag, the request will succeed
// The header can also contain *, in which case the request
// will only succeed if the entity does not exist at all.
$nodeExists = true;
if (!$node) {
try {
$node = $this->tree->getNodeForPath($uri);
} catch (Sabre_DAV_Exception_NotFound $e) {
$nodeExists = false;
}
}
if ($nodeExists) {
$haveMatch = false;
if ($ifNoneMatch==='*')
{
// @XXX BAD BAD FIX
/ $haveMatch = true; /
error_log('sogo bug');
}
else ...
'If-Match' is recommended |
|
|
|
I can confirm that SOGo connector 24.0.2 also sends If-None-Match: * when updating existing contacts. That violates the RFC and causes precondition checks on the server to fail and thus the PUT command to be rejected. |
|
|
|
That's a pretty bad one.
This will basically break compatiblity with any correctly implemented CardDAV server on the planet.
I can confirm that this is an issue with every sabredav implementation, including owncloud, fruux and baikal; but I assume this breaks a lot more servers as If-None-Match: * is a simple enough feature to be implemented in the most simple servers. |
|
|
|
I'm attaching a patch which fixes this issue for me. The patch should enable the Thunderbird connector 24.0.2 to modify vcards on RFC compliant carddav servers.
I have tested with Radicale 0.8
If you are testing, I recommend you apply the patch from bug 0001411 also, and remove the stock xpi, as the patch doesn't change the version number. |
|
|
|
vcard-etags.patch (3,020 bytes)
diff -ur sogo-connector-24.0.2.jdccdevel.1/chrome/content/inverse-library/sogoWebDAV.js sogo-connector-24.0.2.jdccdevel.2/chrome/content/inverse-library/sogoWebDAV.js
--- sogo-connector-24.0.2.jdccdevel.1/chrome/content/inverse-library/sogoWebDAV.js 2013-12-11 15:27:19.635963841 -0700
+++ sogo-connector-24.0.2.jdccdevel.2/chrome/content/inverse-library/sogoWebDAV.js 2013-12-10 16:47:46.647178104 -0700
@@ -558,10 +558,29 @@
}
else if (operation == "PUT" || operation == "POST") {
if(parameters.contentType.indexOf("text/vcard") == 0) {
- this._sendHTTPRequest(operation,
+ if (this.cbData.data.getProperty("groupDavKey", "") == "") {
+ dump("NOTICE: uploading new vcard with empty key\n");
+ this._sendHTTPRequest(operation,
parameters.data,
{ "content-type": parameters.contentType,
"If-None-Match": "*" });
+ }
+ else {
+ let oldDavVersion = this.cbData.data.getProperty("groupDavVersionPrev", "-1");
+ dump("NOTICE: uploading modified vcard with etag: " + oldDavVersion + "\n");
+ if (oldDavVersion != "-1") {
+ this._sendHTTPRequest(operation,
+ parameters.data,
+ { "content-type": parameters.contentType,
+ "If-Match": oldDavVersion });
+ }
+ else {
+ dump("NOTICE: uploading modified vcard without etag\n");
+ this._sendHTTPRequest(operation,
+ parameters.data,
+ { "content-type": parameters.contentType });
+ }
+ }
}
else {
this._sendHTTPRequest(operation,
diff -ur sogo-connector-24.0.2.jdccdevel.1/chrome/content/sogo-connector/addressbook/common-card-overlay.js sogo-connector-24.0.2.jdccdevel.2/chrome/content/sogo-connector/addressbook/common-card-overlay.js
--- sogo-connector-24.0.2.jdccdevel.1/chrome/content/sogo-connector/addressbook/common-card-overlay.js 2013-12-11 15:27:19.635963841 -0700
+++ sogo-connector-24.0.2.jdccdevel.2/chrome/content/sogo-connector/addressbook/common-card-overlay.js 2013-12-10 16:47:54.191178177 -0700
@@ -190,7 +190,9 @@
if (gSCCardValues.documentDirty
&& isGroupdavDirectory(parentURI)) {
SCSaveCategories();
+ let oldDavVersion = gEditCard.card.getProperty("groupDavVersion", "-1");
gEditCard.card.setProperty("groupDavVersion", "-1");
+ gEditCard.card.setProperty("groupDavVersionPrev", oldDavVersion);
let abManager = Components.classes["@mozilla.org/abmanager;1"]
.getService(Components.interfaces.nsIAbManager);
|
|
|
|
Which patch is better? 1411 or 1624? |
|
|
|
Apply them both, they fix different issues. I kept them separate so they could be vetted and applied separately by the maintainers. |
|
|
|
https://github.com/inverse-inc/sogo-connector.tb24/commit/d1b32b97890e996be48b84ab8dae15c2d8c0b9fa |
|
