|Anonymous | Login | Signup for a new account||2019-07-19 20:48 EDT|
|My View | View Issues | Change Log | Roadmap | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002152||SOGo||SOPE||public||2012-12-19 16:54||2013-01-31 16:52|
|Target Version||2.0.4||Fixed in Version||2.0.4|
|Summary||0002152: Users with commas and spaces in their LDAP DNs cannot login|
|Description||When user DN in LDAP contains comma immediately followed by space, SOGo fails to construct correct LDAP binddn for such user.|
dn: CN=Tkac\, Adam,OU=ITZ,DC=geodis,DC=cz
I captured LDAP network traffic and found that SOGo tries to bind with following binddn (note that the space character is missing)
So the LDAP bind obviously fails because DN doesn't exist and SOGo web interface writes that user specified wrong credentials.
I'm using the latest SOGo/SOPE:
|Additional Information||After inspection the main issue is in sope, in sope-ldap/NGLdap/NSString+DN.m:dnComponents method. This method thinks that every comma splits DN. However this is not true when comma is escaped.|
After incorrect split this method removes starting and trailing whitespaces from attributes, so the space from DN disappears.
I will attach proposed patch, which uses ldap_explode_dn to split DN into RDNs.
|Tags||No tags attached.|
|Attached Files||0001-NSString-DN.m-dnComponents-method-failed-to-parse-DN.patch [^] (2,370 bytes) 2012-12-19 16:55 [Show Content]|
Adam Tkac (reporter)
|The patch fixes the login issue in my case, I already verified it. Sorry that it is not so clean but I have no experience with objective-c.|
Fix slightly modified and pushed, thanks!
|New fix as this patch broke utf8 encoding of DNs : https://github.com/inverse-inc/sope/commit/7a8cb886103dc9b4569151ae185b9e3bc2e95b4e [^]|
|2012-12-19 16:54||Adam Tkac||New Issue|
|2012-12-19 16:55||Adam Tkac||File Added: 0001-NSString-DN.m-dnComponents-method-failed-to-parse-DN.patch|
|2012-12-19 16:56||Adam Tkac||Note Added: 0005079|
|2012-12-20 08:51||ludovic||Target Version||=> 2.0.4|
|2013-01-11 11:52||ludovic||Note Added: 0005138|
|2013-01-11 11:52||ludovic||Status||new => closed|
|2013-01-11 11:52||ludovic||Resolution||open => fixed|
|2013-01-11 11:52||ludovic||Fixed in Version||=> 2.0.4|
|2013-01-18 14:59||ludovic||Relationship added||has duplicate 0001407|
|2013-01-31 16:52||jraby||Note Added: 0005303|
|Copyright © 2000 - 2019 MantisBT Team|