View Issue Details

IDProjectCategoryView StatusLast Update
0003819SOGoApple Calendar (Mac OS X)public2017-05-08 19:04
Reporterjk Assigned Toludovic  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionsuspended 
PlatformMacOSOSMacOSOS Version10.11
Product Version2.3.15 
Fixed in Version3.2.0 
Summary0003819: Some VCards exposed via CardDAV don't have a UID and therefore are ignored by MacOS Contacts.app
Description

Contacts.app reports following Error for a lot of contacts, but not all. It's silent in the UI so the user is just confused why only some contacts show up.

The Error Console shows:

23/09/16 14:02:41,202 Contacts[23907]: [CardDAVPlugin-ERROR] CardInfoFromVCardData(): Ignored vCard at /SOGo/dav/bongo/Contacts/personal/6651-4FCD1D00-1DD-1CFE7500 because there is no UID property: "BEGIN:VCARD
VERSION:3.0

redacted

PRODID:-//dmfs.org//mimedir.vcard//EN
REV:20120621T181802Z
END:VCARD

I suspect my Android Phone somehow doesn't create the UID but it's not added by sogo either, I'm using android 6.0.1 and Carddav Syncer of DMFS (popular).

The problem should not only solved by the client but also by sogo since mabye more clients (will) have that bug.

This issue persisted also in earlier versions (just upgraded from 2.2.9)

Steps To Reproduce

Add SOGO to Contacts.app Accounts and sync contacts created on a Android smartphone.

TagsNo tags attached.

Activities

ludovic

ludovic

2016-09-23 15:01

administrator   ~0010653

Please sniff on port 20 000 on your SOGo server using tcpflow and confirm no UID is sent.

jk

jk

2016-09-23 20:33

reporter   ~0010682

I did the tcpflow dump and it shows that there's no UID:

<?xml version="1.0" encoding="utf-8"?>
<D:multistatus xmlns:D="DAV:" xmlns:C="urn:ietf:params:xml:ns:carddav"><D:response><D:href>/SOGo/dav/bongo/Contacts/personal/6651-4FCD1D00-22D-**</D:href><D:propstat><D:prop><C:address-data>BEGIN:VCARD
VERSION:3.0
X-EVOLUTION-FILE-AS:Doe\, John
NOTE:BIRTHDAY=19790101
N:Doe;John;;;
FN:Matthieu Moreau
URL:
TITLE:
ROLE:
X-EVOLUTION-MANAGER:
X-EVOLUTION-ASSISTANT:
NICKNAME:
BDAY:1979-01-01
X-EVOLUTION-SPOUSE:
X-EVOLUTION-BLOG-URL:
CALURI:
FBURL:
X-EVOLUTION-VIDEO-URL:
X-MOZILLA-HTML:FALSE
END:VCARD</C:address-data>

.....

Marten Gajda

Marten Gajda

2016-09-27 23:14

reporter   ~0010699

FTR: the VCard in the description was created by an ancient Version of CardDAV-Sync. Recent versions always add a UID before uploading a new contact.

jk

jk

2016-10-04 09:54

reporter   ~0010720

Last edited: 2016-10-10 17:51

I can still reproduce the behaviour with the latest nightly 3.2.0.20161004-1 and 3.2.0.20161010-1

jk

jk

2016-10-29 22:16

reporter   ~0010797

Okay, since that does not seem to be fixed for now, I helped myself with fixing the VCF files myself.

For the interested:

#!/bin/bash

for card in ls **/*; do

grep -i "^UID:" $card > /dev/null
if [ $? -ne 0 ];then
echo "###################"
#cat $card
echo $card
echo adding uid to card
echo "UID:"$(uuidgen) # >> $card
echo "####################"
fi

done

ludovic

ludovic

2017-05-08 19:04

administrator   ~0011802

Uploaded cards will always have a UID.

Old cards can be fixed manually, it was a bug in CardDAV-Sync.

Related Changesets

sogo: master 8ec73590

2016-09-27 19:49

ludovic


Details Diff
(fix) make sure new cards always have a UID (fixes 0003819) Affected Issues
0003819
mod - SoObjects/Contacts/SOGoContactGCSEntry.m Diff File

sogo: v2 156a8304

2016-09-27 19:49

ludovic


Details Diff
(fix) make sure new cards always have a UID (fixes 0003819) Affected Issues
0003819
mod - SoObjects/Contacts/SOGoContactGCSEntry.m Diff File

Issue History

Date Modified Username Field Change
2016-09-23 12:26 jk New Issue
2016-09-23 15:01 ludovic Note Added: 0010653
2016-09-23 15:01 ludovic Severity major => minor
2016-09-23 20:33 jk Note Added: 0010682
2016-09-27 23:14 Marten Gajda Note Added: 0010699
2016-09-27 23:52 ludovic Changeset attached => sogo master 8ec73590
2016-09-27 23:52 ludovic Assigned To => ludovic
2016-09-27 23:52 ludovic Resolution open => fixed
2016-09-27 23:53 ludovic Changeset attached => sogo v2 156a8304
2016-09-27 23:53 ludovic Status new => resolved
2016-09-27 23:53 ludovic Fixed in Version => 3.2.0
2016-10-04 09:54 jk Note Added: 0010720
2016-10-04 09:54 jk Status resolved => feedback
2016-10-04 09:54 jk Resolution fixed => reopened
2016-10-10 17:51 jk Note Edited: 0010720
2016-10-29 22:16 jk Note Added: 0010797
2016-10-29 22:16 jk Status feedback => assigned
2017-05-08 19:04 ludovic Note Added: 0011802
2017-05-08 19:04 ludovic Status assigned => closed
2017-05-08 19:04 ludovic Resolution reopened => suspended