amair
2024-02-08 13:07
reporter
|
sogo-5.9.1-vlist.patch (410 bytes)
diff -Nur SOGo-5.9.1/SoObjects/SOGo/WORequest+SOGo.h SOGo-5.9.1.debug/SoObjects/SOGo/WORequest+SOGo.h
--- SOGo-5.9.1/SoObjects/SOGo/WORequest+SOGo.h 2023-12-12 13:18:09.000000000 +0100
+++ SOGo-5.9.1.debug/SoObjects/SOGo/WORequest+SOGo.h 2024-02-08 09:29:20.956000000 +0100
@@ -37,6 +37,7 @@
- (BOOL) isIPhoneAddressBookApp;
- (BOOL) isAndroid;
- (BOOL) isMacOSXCalendar;
+- (BOOL) isThunderbird;
@end
|
|
|
|
It seems to be related to your build tools.
You need to create a pull request.
Sebastien |
|
|
|
As all the other "is" methods are defined in SoObjects/SOGo/WORequest+SOGo.h I'd say "isThunderbird" simply was forgotten. If it works by accident with your build tools, lucky you.
You have the patch, do whatever you want with it.
This is what GCC reports:
SOGoGCSFolder.m: In function ‘-[SOGoGCSFolder toOneRelationshipKeys]’:
SOGoGCSFolder.m:743:7: warning: ‘WORequest’ may not respond to ‘-isThunderbird’
743 | if ([[context request] isThunderbird] && [self isKindOfClass: NSClassFromString(@"SOGoContactGCSFolder")]) {
| ^~
SOGoGCSFolder.m: In function ‘-[SOGoGCSFolder _fetchFields:withQualifier:ignoreDeleted:]’:
SOGoGCSFolder.m:1196:3: warning: ‘WORequest’ may not respond to ‘-isThunderbird’
1196 | if ([[context request] isThunderbird] && [self isKindOfClass: NSClassFromString(@"SOGoContactGCSFolder")]) {
| ^~
|
|
|
|
First of all, I agree the method is missing in the header file.
However, this is a warning and this should not mess up during runtime - that's why the compiler doesn't stop compiling.
This is why you can use reflection mechanism through respondsToSelector on objects, but you're probably unfamiliar with those concepts. |
|
|
|
For next time contributors must do pull request on github |
|
